Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: setup e2e tests #187

Merged
merged 1 commit into from
Jun 28, 2024
Merged

test: setup e2e tests #187

merged 1 commit into from
Jun 28, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jun 27, 2024 •
edited
Loading

  • Add playwright
  • Add ci job
  • Add connect wallet test
  • Remove type module

Note: sometimes due to rpc timeouts, some tests can fail but it can be fixed with rerun.

@0xmad 0xmad added the chore Chore tasks label Jun 27, 2024
@0xmad 0xmad self-assigned this Jun 27, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-rpgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 2:36pm

@0xmad 0xmad marked this pull request as ready for review June 28, 2024 13:57
@0xmad
test: setup e2e tests
c116729 
- [x] Add playwright
- [x] Add ci job
- [x] Add connect wallet test
- [x] Remove type module
ctrlc03
ctrlc03 reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you, just left 2 comments/questions

.env.example Show resolved Hide resolved
package.json Show resolved Hide resolved
@0xmad 0xmad requested a review from ctrlc03 June 28, 2024 15:26
@0xmad 0xmad enabled auto-merge June 28, 2024 15:34
ctrlc03
ctrlc03 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@0xmad 0xmad merged commit c2f3c23 into main Jun 28, 2024
11 checks passed
@0xmad 0xmad deleted the test/e2e-setup branch June 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@0xmad 0xmad

Labels
chore Chore tasks
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmad @ctrlc03